Re: [PATCH] i2c-pxa2xx: fix missing pci_disable_device() on error in ce4100_i2c_probe

From: Wolfram Sang
Date: Mon Dec 05 2022 - 05:02:05 EST


On Mon, Nov 14, 2022 at 05:25:40PM +0800, Hui Tang wrote:
> Using pcim_enable_device() to avoid missing pci_disable_device().
>
> Fixes: 7e94dd154e934 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")
> Signed-off-by: Hui Tang <tanghui20@xxxxxxxxxx>

Fixed the subject to "i2c: pxa-pci:" and fixed this checkpatch warning:

WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 7e94dd154e93 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")'
#3:
Fixes: 7e94dd154e934 ("i2c-pxa2xx: Add PCI support for PXA I2C controller")

Please do that in the future. After all that, applied to for-next, thanks!

Attachment: signature.asc
Description: PGP signature