Re: [PATCH -next V8 04/14] riscv: ptrace: Remove duplicate operation

From: Björn Töpel
Date: Mon Dec 05 2022 - 04:34:33 EST


guoren@xxxxxxxxxx writes:

> From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> The TIF_SYSCALL_TRACE is controlled by a common code, see
> kernel/ptrace.c and include/linux/thread.h.

^^^ thread_info.h
>
> clear_task_syscall_work(child, SYSCALL_TRACE);
>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Guo Ren <guoren@xxxxxxxxxx>
> Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---
> arch/riscv/kernel/ptrace.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c
> index 2ae8280ae475..44f4b1ca315d 100644
> --- a/arch/riscv/kernel/ptrace.c
> +++ b/arch/riscv/kernel/ptrace.c
> @@ -212,7 +212,6 @@ unsigned long regs_get_kernel_stack_nth(struct pt_regs *regs, unsigned int n)
>
> void ptrace_disable(struct task_struct *child)
> {
> - clear_tsk_thread_flag(child, TIF_SYSCALL_TRACE);
> }
>
> long arch_ptrace(struct task_struct *child, long request,

This patch is also not neccesary for the series, but should be a
separate cleanup.