Re: [PATCH] trace: Fix some checker warnings

From: Steven Rostedt
Date: Sun Dec 04 2022 - 22:29:34 EST


On Mon, 5 Dec 2022 12:11:19 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> > #if (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
> > || defined(CONFIG_OSNOISE_TRACER)) && defined(CONFIG_FSNOTIFY)
> > #define LATENCY_FS_NOTIFY
> > +#define USES_MAX_TRACE
> > #endif
> >
> > And use that instead.
>
> BTW, why can't HWLAT_TRACER and OSNOISE_TRACER depend on TRACER_MAX_TRACE?
> I think it is better to reduce combinations of those, especially partially
> enabling a feature seems a bit dangerous.

Well, the issue with that is that if the TRACER_MAX_TRACE is off
(because it's not something commonly selected), it will hide osnoise
and hwlat from showing up in the menus.

-- Steve