Re: [PATCH v2] infiniband: disable IB HW for UML

From: Randy Dunlap
Date: Sun Dec 04 2022 - 11:10:24 EST




On 12/4/22 05:21, Leon Romanovsky wrote:
> On Fri, Dec 02, 2022 at 01:19:40PM -0800, Randy Dunlap wrote:
>> Disable all of drivers/infiniband/hw/ for UML builds until someone
>> needs it and provides patches to support it.
>>
>> This prevents build errors in hw/qib/qib_wc_x86_64.c.
>>
>> Fixes: 68f5d3f3b654 ("um: add PCI over virtio emulation driver")
>> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>> Suggested-by: Leon Romanovsky <leon@xxxxxxxxxx>
>> Cc: Jason Gunthorpe <jgg@xxxxxxxxxx>
>> Cc: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx>
>> Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
>> Cc: linux-rdma@xxxxxxxxxxxxxxx
>> Cc: Jeff Dike <jdike@xxxxxxxxxxx>
>> Cc: Richard Weinberger <richard@xxxxxx>
>> Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>
>> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
>> Cc: linux-um@xxxxxxxxxxxxxxxxxxx
>> ---
>> v2: just disable infiniband/hw/, not all of infiniband.
>>
>> drivers/infiniband/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>
> I added rdmavt to the mix and applied.

Sounds good. Thanks.

> https://lore.kernel.org/linux-rdma/20221130200958.25305-1-rdunlap@xxxxxxxxxxxxx/
>
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 6ee97c898231..a5827d11e934 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -95,8 +95,8 @@ source "drivers/infiniband/hw/qedr/Kconfig"
> source "drivers/infiniband/hw/qib/Kconfig"
> source "drivers/infiniband/hw/usnic/Kconfig"
> source "drivers/infiniband/hw/vmw_pvrdma/Kconfig"
> -endif # !UML
> source "drivers/infiniband/sw/rdmavt/Kconfig"
> +endif # !UML
> source "drivers/infiniband/sw/rxe/Kconfig"
> source "drivers/infiniband/sw/siw/Kconfig"
> endif
> (END)

--
~Randy