Re: [PATCH v2] Documentation: sched: Add a new sched-util-clamp.rst

From: Qais Yousef
Date: Sat Dec 03 2022 - 08:40:33 EST


On 11/29/22 10:16, Bagas Sanjaya wrote:
> On Sun, Nov 27, 2022 at 02:26:57PM +0000, Qais Yousef wrote:
> > The new util clamp feature needs a document explaining what it is and
> > how to use it. The new document hopefully covers everything one needs to
> > know about uclamp.
> >
>
> For patch subject, better say "Documentation: sched: Document util clamp
> feature".

ACK.

>
> > Signed-off-by: Qais Yousef <qais.yousef@xxxxxxx>
> > Signed-off-by: Qais Yousef (Google) <qyousef@xxxxxxxxxxx>
> > ---
> >
> > Changes in v2:
> >
> > * Address various style comments from Bagas
> >
>
> I don't see any of my wording suggestions from [1] being applied. Still
> a rather confused to read (maybe should be applied on top of jon's
> suggestions)?

Apologies! It was an oversight from my side when I revisited the thread and
reworked the patch. I got confused somehow.

All applied now almost as is. There was one tweak that used "40% utilization"
that I replaced with "40% performance level" instead.

Thanks a lot!

Cheers

--
Qais Yousef

>
> [1]: https://lore.kernel.org/lkml/Y3II59dyKuvQGIhG@xxxxxxxxx/
> [2]: https://lore.kernel.org/linux-doc/87cz976pwn.fsf@xxxxxxxxxxxx/