Re: [PATCH v5 2/2] RDMA/srp: Fix error return code in srp_parse_options()

From: Bart Van Assche
Date: Fri Dec 02 2022 - 18:06:42 EST


On 12/1/22 20:00, Wang Yufen wrote:
In the previous iteration of the while loop, the "ret" may have been
assigned a value of 0, so the error return code -EINVAL may have been
incorrectly set to 0. To fix set valid return code before calling to
goto. Also investigate each case separately as Andy suggessted.

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>