Re: [PATCH v3] crypto: caam: blob_gen.c: warn if key is insecure

From: Nikolaus Voss
Date: Fri Dec 02 2022 - 09:43:44 EST


On Fri, 2 Dec 2022, Ahmad Fatoum wrote:
On 21.11.22 15:12, Nikolaus Voss wrote:
+ ctrlpriv = dev_get_drvdata(jrdev->parent);
+ moo = FIELD_GET(CSTA_MOO, ioread32(&ctrlpriv->ctrl->perfmon.status));

Sorry for not having spotted this the first time, but ioread32 is not
completely correct here as the CAAM may be big endian while the CPU is
little endian.

You should be using rd_reg32 here.

Ok.

Herbert, shall I spin v3 of the patch or patch against v2?

Niko