Re: [PATCH v3,1/3] media: dt-bindings: media: mediatek: vcodec: Fix clock num not correctly

[AngeloGioacchino Del Regno]

Il 02/12/22 00:57, Rob Herring ha scritto:
> On Thu, Dec 01, 2022 at 08:15:22PM +0800, Yunfei Dong wrote:
> > From: Yunfei Dong <yunfei.dong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> >
> > mt8195 and mt8192 have different clock numbers, can't write 'clocks' and
> > 'clock-names' with const value.
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>
> > ---
> > Reference series:
> > [1]: v5 of this series is presend by Allen-KH Cheng.
> >       message-id: 20221128143832.25584-4-allen-kh.cheng@xxxxxxxxxxxx
> > ---
> >   .../bindings/media/mediatek,vcodec-subdev-decoder.yaml   | 9 +++------
> >   1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> > index 7c5b4a91c59b..09781ef02193 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-decoder.yaml
> > @@ -110,15 +110,12 @@ patternProperties:
> >             Refer to bindings/iommu/mediatek,iommu.yaml.
> >   
> >         clocks:
> > +        minItems: 1
> >           maxItems: 5
> >   
> >         clock-names:
> > -        items:
> > -          - const: sel
> > -          - const: soc-vdec
> > -          - const: soc-lat
> > -          - const: vdec
> > -          - const: top
> > +        minItems: 1
> > +        maxItems: 5
>
> Names need to be defined. This is a step backwards.

I was thinking the same but wanted to wait for someone else's opinion before.

Yunfei, this would be...

- if:
    properties:
      compatible:
        .... mt8192
  then:
     clock-names:
        .... whatever we have

- if:
   properties... blah mt8195
  then:
    clock-names:
        ..... new ones

...you should know already, but I'm just trying to speed up things here.

Cheers,
Angelo

> Rob
>
> >   
> >         assigned-clocks:
> >           maxItems: 1
> > --
> > 2.18.0