Re: [PATCH v8 02/11] clk: meson: a1: add support for Amlogic A1 PLL clock driver

From: Dmitry Rokosov
Date: Fri Dec 02 2022 - 06:31:32 EST


On Fri, Dec 02, 2022 at 12:16:12PM +0100, Jerome Brunet wrote:
> > drivers/clk/meson/Kconfig | 9 +
> > drivers/clk/meson/Makefile | 1 +
> > drivers/clk/meson/a1-pll.c | 360 +++++++++++++++++++++++++++++++++++++
> > drivers/clk/meson/a1-pll.h | 56 ++++++
> > 4 files changed, 426 insertions(+)
> > create mode 100644 drivers/clk/meson/a1-pll.c
> > create mode 100644 drivers/clk/meson/a1-pll.h
> >
> > diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> > index fc002c155bc3..ab34662b24f0 100644
> > --- a/drivers/clk/meson/Kconfig
> > +++ b/drivers/clk/meson/Kconfig
> > @@ -99,6 +99,15 @@ config COMMON_CLK_AXG_AUDIO
> > Support for the audio clock controller on AmLogic A113D devices,
> > aka axg, Say Y if you want audio subsystem to work.
> >
> > +config COMMON_CLK_A1_PLL
> > + bool
>
> Could you add a tristate with some text please ?
>

Yep... I did it in my fixup patches :-) Looks like it's better to review
the next version with already squashed patches.

--
Thank you,
Dmitry