Re: [PATCH v8 08/11] dt-bindings: clock: meson: fixup A1 PLL clkc dtb_check errors

From: Krzysztof Kozlowski
Date: Fri Dec 02 2022 - 05:40:49 EST


On 01/12/2022 23:57, Dmitry Rokosov wrote:
> During running dtbs_check and dt_binding_check checkers the following
> problems were found and resolved:
> - $id is not correct, it has wrong url path
> - CLKIDs aren't applied by names, just magic int constants there
> - address and size cells are required for long reg definition
> - wrong indentations
>
> Also this patch adds new A1 clk controllers dt bindings to MAINTAINERS.
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx>
> ---
> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 27 ++++++++++++-------
> MAINTAINERS | 1 +
> 2 files changed, 18 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
> index d67250fbeece..83f98a73c04e 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-pll-clkc.yaml
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: "http://devicetree.org/schemas/amlogic,a1-pll-clkc.yaml#";
> +$id: "http://devicetree.org/schemas/clock/amlogic,a1-pll-clkc.yaml#";
> $schema: "http://devicetree.org/meta-schemas/core.yaml#";
>
> title: Amlogic Meson A/C serials PLL Clock Control Unit Device Tree Bindings

NAK.

This must be squashed.

Best regards,
Krzysztof