Re: [PATCH -next] selftests/ptrace: Fix Test terminated by timeout in ptrace_attach

From: Kees Cook
Date: Thu Dec 01 2022 - 19:48:27 EST


On Mon, Nov 28, 2022 at 08:56:09AM +0100, Bernd Edlinger wrote:
> thanks for cleaning this up.

Oh, hm, I never saw the original email -- I'll check my Spam folder, it
gets overly excited sometimes.

> Just for completenes:
>
> I have actually two patches submitted a while ago, but did not get any response so far,
> one that would make the test case work as it is:
>
> [PATCH v10] exec: Fix dead-lock in de_thread with ptrace_attach
> https://lore.kernel.org/lkml/AM8PR10MB470801D01A0CF24BC32C25E7E40E9@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
>
> and my favorite one, that would fix the dead-lock altogether (and adjust the test case accordingly):
>
> [PATCH v11] exec: Fix dead-lock in de_thread with ptrace_attach
> https://lore.kernel.org/lkml/AM8PR10MB470875B22B4C08BEAEC3F77FE4169@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

This fell off my radar, but let's look at it again. Is this still an
existing race after Eric's various refactorings? I assume so. Eric, can
you looked at this case?

--
Kees Cook