Re: [PATCH v2] arm64: dts: qcom: sa8540p-ride: enable PCIe support

From: Brian Masney
Date: Thu Dec 01 2022 - 17:36:11 EST


On Thu, Dec 01, 2022 at 04:30:12PM -0600, Bjorn Andersson wrote:
> On Thu, Dec 01, 2022 at 12:19:31PM -0500, Brian Masney wrote:
> > + vreg_l11a: ldo11 {
> > + regulator-name = "vreg_l11a";
> > + regulator-min-microvolt = <880000>;
> > + regulator-max-microvolt = <880000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> > + regulator-allow-set-load;
>
> In order to specify regulator-allow-set-load you also need
> regulator-allowed-modes.
>
> But if I read the implementation correction, we don't actually alter the
> load, so perhaps best to just omit this for now?

I can drop regulator-allow-set-load in v3. I almost left it off and
verified the other day that PCIe still works without it.

Brian