Re: [PATCH 1/2] interconnect: qcom: Add SM6115 interconnect provider driver

[Konrad Dybcio]

On 30.11.2022 11:38, Bhupesh Sharma wrote:
> Add driver for the Qualcomm interconnect buses found in SM6115 based
> platforms. The topology consists of several NoCs that are controlled by
> a remote processor that collects the aggregated bandwidth for each
> master-slave pairs.
> 
> Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> ---

[...]

> +MODULE_DEVICE_TABLE(of, sm6115_qnoc_of_match);
> +
> +static struct platform_driver sm6115_qnoc_driver = {
> +	.probe = qnoc_probe,
> +	.remove = qnoc_remove,
> +	.driver = {
> +		.name = "qnoc-sm6115",
> +		.of_match_table = sm6115_qnoc_of_match,
No .sync_state?

> +	},
> +};
> +module_platform_driver(sm6115_qnoc_driver);
> +
> +MODULE_DESCRIPTION("Qualcomm SM6115 NoC driver");
> +MODULE_LICENSE("GPL v2");
"GPL", checkpatch should have pointed that out.

Otherwise lgtm

Konrad