Re: [PATCH 01/10] mm/hugetlb: Let vma_offset_start() to return start

From: David Hildenbrand
Date: Wed Nov 30 2022 - 05:12:41 EST


On 29.11.22 20:35, Peter Xu wrote:
Even though vma_offset_start() is named like that, it's not returning "the
start address of the range" but rather the offset we should use to offset
the vma->vm_start address.

Make it return the real value of the start vaddr, and it also helps for all
the callers because whenever the retval is used, it'll be ultimately added
into the vma->vm_start anyway, so it's better.

... the function name is a bit unfortunate ("offset" what?, "start" what?).

But it now matches the semantics of vma_offset_end() and the actual "v_start" variables.

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb