Re: [PATCH V4 3/8] null_blk: initialize cmd->bio in __alloc_cmd()

From: Shinichiro Kawasaki
Date: Wed Nov 30 2022 - 03:01:50 EST


On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> The function __alloc_cmd() is responsible to allocate tag and
> initialize the different members of the null_cmd structure e.g.
> cmd->tag, cmd->error, and cmd->nq, Move only member bio that is initialized
> from alloc_cmd() into __alloc_cmd().
>
> Signed-off-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
> Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>

--
Shin'ichiro Kawasaki