Re: [PATCH v2 06/26] drm: sun4i: Define and use generic PM ops

From: Samuel Holland
Date: Tue Nov 29 2022 - 23:08:57 EST


On 11/29/22 13:17, Paul Cercueil wrote:
> Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a
> "struct dev_pm_ops" that can be used by this driver, instead of using
> custom PM callbacks with the same behaviour.
>
> v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an
> exported dev_pm_ops.
>
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
>
> Samuel: since the code changed I had to remove your reviewed-by, sorry
> about that.
>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> Cc: Samuel Holland <samuel@xxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-sunxi@xxxxxxxxxxxxxxx
> ---
> drivers/gpu/drm/sun4i/sun4i_drv.c | 26 ++++----------------------
> 1 file changed, 4 insertions(+), 22 deletions(-)

Reviewed-by: Samuel Holland <samuel@xxxxxxxxxxxx>