Re: [PATCH v2] iommu/vt-d: Add a fix for devices need extra dtlb flush

From: Jacob Pan
Date: Tue Nov 29 2022 - 19:30:28 EST


Hi Baolu,

On Wed, 30 Nov 2022 08:10:55 +0800, Baolu Lu <baolu.lu@xxxxxxxxxxxxxxx>
wrote:

> > --- a/drivers/iommu/intel/iommu.c
> > +++ b/drivers/iommu/intel/iommu.c
> > @@ -1396,6 +1396,23 @@ static void domain_update_iotlb(struct
> > dmar_domain *domain) spin_unlock_irqrestore(&domain->lock, flags);
> > }
> >
> > +/*
> > + * Impacted QAT device IDs ranging from 0x4940 to 0x4943.
> > + * This quirk is exempted from risky_device() check because it applies
> > only
> > + * to the built-in QAT devices.
> > + */
>
> How about adding:
>
> "This quirk is exempted from risky_device() check because it doesn't
> effectively grant additional privileges."
sounds good.

Thanks,

Jacob