Re: [PATCH 1/1] iio: imx8qxp-adc: fix irq flood when call imx8qxp_adc_read_raw()

[Lars-Peter Clausen]

On 11/29/22 08:45, Frank Li wrote:
		       readl(adc->regs + IMX8QXP_ADR_ADC_FCTRL));
> @@ -272,6 +275,10 @@ static irqreturn_t imx8qxp_adc_isr(int irq, void *dev_id)
>   	if (fifo_count)
>   		complete(&adc->completion);

Shouldn't the completion be triggered after the reading of the samples? 
otherwise you have a race condition on a multi-processor system.

>   
> +	for (i = 0; i < fifo_count; i++)
> +		adc->fifo[i] = FIELD_GET(IMX8QXP_ADC_RESFIFO_VAL_MASK,
> +				readl_relaxed(adc->regs + IMX8QXP_ADR_ADC_RESFIFO));
> +
>   	return IRQ_HANDLED;
>   }
>