Re: [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h>

From: Masahiro Yamada
Date: Tue Nov 29 2022 - 04:32:53 EST


On Tue, Nov 29, 2022 at 10:18 AM Russ Weight <russell.h.weight@xxxxxxxxx> wrote:
>
>
>
> On 11/25/22 21:09, Thomas Weißschuh wrote:
> > utsrelease.h is potentially generated on each build.
> > By removing this unused include we can get rid of some spurious
> > recompilations.
> Reviewed-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > ---
> > drivers/base/firmware_loader/firmware.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h
> > index fe77e91c38a2..bf549d6500d7 100644
> > --- a/drivers/base/firmware_loader/firmware.h
> > +++ b/drivers/base/firmware_loader/firmware.h
> > @@ -9,8 +9,6 @@
> > #include <linux/list.h>
> > #include <linux/completion.h>
> >
> > -#include <generated/utsrelease.h>
> > -
> > /**
> > * enum fw_opt - options to control firmware loading behaviour
> > *
> >
> > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536
>

Applied to linux-kbuild.
Thanks.

--
Best Regards
Masahiro Yamada