Re: [PATCH v4 1/2] RDMA/hfi1: Fix error return code in parse_platform_config()

From: Leon Romanovsky
Date: Tue Nov 29 2022 - 03:56:20 EST


On Tue, Nov 29, 2022 at 10:04:18AM +0800, Wang Yufen wrote:
> In the previous while loop, "ret" may be assigned zero, so the error
> return code may be incorrectly set to 0 instead of -EINVAL.
>
> Fixes: 97167e813415 ("staging/rdma/hfi1: Tune for unknown channel if configuration file is absent")
> Signed-off-by: Wang Yufen <wangyufen@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/hfi1/firmware.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>

Thanks, LGTM.

@Dennis?