Re: [PATCH net-next v5 3/4] net: devlink: make the devlink_ops::info_get() callback optional

From: Jiri Pirko
Date: Tue Nov 29 2022 - 03:26:47 EST


Tue, Nov 29, 2022 at 01:05:49AM CET, mailhol.vincent@xxxxxxxxxx wrote:
>Some drivers only reported the driver name in their
>devlink_ops::info_get() callback. Now that the core provides this
>information, the callback became empty. For such drivers, just
>removing the callback would prevent the core from executing
>devlink_nl_info_fill() meaning that "devlink dev info" would not
>return anything.
>
>Make the callback function optional by executing
>devlink_nl_info_fill() even if devlink_ops::info_get() is NULL.
>
>N.B.: the drivers with devlink support which previously did not
>implement devlink_ops::info_get() will now also be able to report
>the driver name.
>
>Signed-off-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>

Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>