Re: [PATCH] drm/amdkfd: Fix memory leakage

[Felix Kuehling]

Am 2022-11-28 um 22:47 schrieb Konstantin Meskhidze:
> This patch fixes potential memory leakage and seg fault
> in  _gpuvm_import_dmabuf() function
>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@xxxxxxxxxx>

Thank you for the patch. I'm adding a Fixes tag and pushing the patch to 
amd-staging-drm-next.

Fixes: d4ec4bdc0bd5 ("drm/amdkfd: Allow access for mmapping KFD BOs")
Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 978d3970b5cc..e0084f712e02 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -2257,7 +2257,7 @@ int amdgpu_amdkfd_gpuvm_import_dmabuf(struct amdgpu_device *adev,
>   
>   	ret = drm_vma_node_allow(&obj->vma_node, drm_priv);
>   	if (ret) {
> -		kfree(mem);
> +		kfree(*mem);
>   		return ret;
>   	}
>