Re: [PATCH 5/9] dt-bindings: spi: mtk-snfi: add mt7986 IC snfi bindings

From: Xiangsheng Hou (侯祥胜)
Date: Mon Nov 28 2022 - 21:50:22 EST


Hi Krzysztof,

On Mon, 2022-11-28 at 10:00 +0100, Krzysztof Kozlowski wrote:
> On 28/11/2022 03:06, Xiangsheng Hou wrote:
> > 1. add mt7986 IC bindings
>
> Subject: drop second, redundant "bindings".
Will be fixed in next series.

> > clocks:
> > + minItems: 2
> > items:
> > - description: clock used for the controller
> > - description: clock used for the SPI bus
> > + - description: clock used for the AHB bus dma bus, this
> > depends on
> > + hardware design, so this is optional.
>
> Optional for which variants? For all of them?
It`s only needed for the item 3 nfi_hclk. Is it proper with this
description or any other suggestion.

>
> >
> > clock-names:
> > + minItems: 2
> > items:
> > - const: nfi_clk
> > - const: pad_clk
> > + - const: nfi_hclk
>

Best regards,
Xiangsheng Hou