Re: [PATCH v1 net 2/2] vmxnet3: use correct intrConf reference when using extended queues

From: Ronak Doshi
Date: Mon Nov 28 2022 - 19:35:36 EST



On 11/28/22, 3:49 PM, "Jacob Keller" <jacob.e.keller@xxxxxxxxx> wrote:
> !! External Email
>
> On 11/28/2022 11:32 AM, Ronak Doshi wrote:
> > 'Commit 39f9895a00f4 ("vmxnet3: add support for 32 Tx/Rx queues")'
> > added support for 32Tx/Rx queues. As a part of this patch, intrConf
> > structure was extended to incorporate increased queues.
> >
>
> Nit: no need to quote around the commit reference here.
>
> I don't personally think its worth a re-roll to fix that, but good to be
> aware of in future submission.
>
> The patch itself makes sense.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

Thanks, Jacob, for the review.