Re: [PATCH] kprobes: Fix check for probe enabled in kill_kprobe()

[Steven Rostedt]

On Mon, 28 Nov 2022 17:48:43 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> On Sat, 26 Nov 2022 19:43:16 +0800
> Li Huafei <lihuafei1@xxxxxxxxxx> wrote:
> 
> > In kill_kprobe(), the check whether disarm_kprobe_ftrace() needs to be
> > called always fails. This is because before that we set the
> > KPROBE_FLAG_GONE flag for kprobe so that "!kprobe_disabled(p)" is always
> > false.  
> 
> Good catch!
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> 
> Thank you!

Looks good.

Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve