Re: [PATCH v4 3/3] arm64: dts: qcom: sc8280xp-x13s: Add soundcard support

[Srinivas Kandagatla]

On 28/11/2022 12:58, Krzysztof Kozlowski wrote:
> On 28/11/2022 13:44, Krzysztof Kozlowski wrote:
> > On 23/11/2022 11:43, Srinivas Kandagatla wrote:
> > > +
> > > +&swr1 {
> > > +	status = "okay";
> > > +
> > > +	wcd_rx: wcd9380-rx@0,4 {
> > > +		compatible = "sdw20217010d00";
> > > +		reg = <0 4>;
> > > +		qcom,rx-port-mapping = <1 2 3 4 5>;
> > > +	};
> > > +};
> > > +
> > > +&swr2 {
> > > +	status = "okay";
> > > +
> > > +	wcd_tx: wcd9380-tx@0,3 {
> > > +		compatible = "sdw20217010d00";
> > > +		reg = <0 3>;
> > > +		qcom,tx-port-mapping = <1 1 2 3>;
> >
> > I think I solved my head-phones one-channel problem.
> > This should be <1 2 3> and in DTSI:
> > qcom,din-ports = <3>;

WCD938x TX device has 4 SoundWire ports and LPASS TX macro SoundWire 
Master has 3 ports this mapping qcom,tx-port-mapping = <1 1 2 3>; 
defines how wcd device SoundWire ports are connected to SoundWire Master 
port.


> > The downstream waipio-audio-overlay.dtsi says:
> >
> >   56                         qcom,swr-port-mapping = <1 SWRM_TX1_CH1 0x1>,
> >   57                                 <1 SWRM_TX1_CH2 0x2>,
> >   58                                 <1 SWRM_TX1_CH3 0x4>, <1 SWRM_TX1_CH4 0x8>,
> >   59                                 <2 SWRM_TX2_CH1 0x1>, <2 SWRM_TX2_CH2 0x2>,
> >   60                                 <2 SWRM_TX2_CH3 0x4>, <2 SWRM_TX2_CH4 0x8>,
> >   61                                 <3 SWRM_TX3_CH1 0x1>, <3 SWRM_TX3_CH2 0x2>,
> >   62                                 <3 SWRM_TX3_CH3 0x4>, <3 SWRM_TX3_CH4 0x8>;
> >
> > I just don't know what how to trim the port config properties - we
> > have there four entries, but channels are only three?
> >
> > Where do these come from? The downstream:
> > asoc/waipio-port-config.h / lahaina-port-config.h
> > Do do not have port config for this SWR.

yes, that along with dts is the source for this information.

--srini
> Eh, not sure anymore. My second headphone started to work without these
> changes, so I have no clue.
>
> Best regards,
> Krzysztof