Re: [PATCH] s390/mm: Use pmd_pgtable_page() helper in __gmap_segment_gaddr()

[Alexander Gordeev]

On Mon, Nov 28, 2022 at 12:01:06PM +0530, Anshuman Khandual wrote:
> >> diff --git a/include/linux/mm.h b/include/linux/mm.h
> >> index e9e387caffac..5ead9e997510 100644
> >> --- a/include/linux/mm.h
> >> +++ b/include/linux/mm.h
> >> @@ -2403,7 +2403,7 @@ static inline void pgtable_pte_page_dtor(struct page *page)
> >>  
> >>  #if USE_SPLIT_PMD_PTLOCKS
> >>  
> >> -static struct page *pmd_pgtable_page(pmd_t *pmd)
> >> +static inline struct page *pmd_pgtable_page(pmd_t *pmd)
> >>  {
> >>  	unsigned long mask = ~(PTRS_PER_PMD * sizeof(pmd_t) - 1);
> >>  	return virt_to_page((void *)((unsigned long) pmd & mask));
> > 
> > This chunk does not appear to belong to this patch.
> 
> Should not this helper be made a 'static inline' before using it else where ?

Probably yes, but it is not kvm s390-specific change.

I guess, you wanted to make it together or as a follow-up to this one?
https://lore.kernel.org/all/20221124131641.1523772-1-anshuman.khandual@xxxxxxx/