Re: [PATCH 002/606] tpm: tpm_i2c_atmel: Convert to i2c's .probe_new()

From: Jarkko Sakkinen
Date: Sun Nov 27 2022 - 20:15:29 EST


On Fri, Nov 18, 2022 at 11:35:36PM +0100, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/char/tpm/tpm_i2c_atmel.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
> index 4be3677c1463..8f77154e0550 100644
> --- a/drivers/char/tpm/tpm_i2c_atmel.c
> +++ b/drivers/char/tpm/tpm_i2c_atmel.c
> @@ -146,8 +146,7 @@ static const struct tpm_class_ops i2c_atmel = {
> .req_canceled = i2c_atmel_req_canceled,
> };
>
> -static int i2c_atmel_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int i2c_atmel_probe(struct i2c_client *client)
> {
> struct tpm_chip *chip;
> struct device *dev = &client->dev;
> @@ -204,7 +203,7 @@ static SIMPLE_DEV_PM_OPS(i2c_atmel_pm_ops, tpm_pm_suspend, tpm_pm_resume);
>
> static struct i2c_driver i2c_atmel_driver = {
> .id_table = i2c_atmel_id,
> - .probe = i2c_atmel_probe,
> + .probe_new = i2c_atmel_probe,
> .remove = i2c_atmel_remove,
> .driver = {
> .name = I2C_DRIVER_NAME,
> --
> 2.38.1
>

Acked-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>

BR, Jarkko