Re: [PATCH v7 1/5] dt-bindings: PCI: ti,j721e-pci-*: add checks for num-lanes

From: Krzysztof Kozlowski
Date: Sat Nov 26 2022 - 09:30:28 EST


On 24/11/2022 09:12, Matt Ranostay wrote:
> Add num-lanes schema checks based on compatible string on available lanes
> for that platform.
>
> Signed-off-by: Matt Ranostay <mranostay@xxxxxx>
> ---
> .../bindings/pci/ti,j721e-pci-ep.yaml | 28 +++++++++++++++++--
> .../bindings/pci/ti,j721e-pci-host.yaml | 28 +++++++++++++++++--
> 2 files changed, 50 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
> index 10e6eabdff53..1aeea168d3d0 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
> @@ -10,9 +10,6 @@ title: TI J721E PCI EP (PCIe Wrapper)
> maintainers:
> - Kishon Vijay Abraham I <kishon@xxxxxx>
>
> -allOf:
> - - $ref: "cdns-pcie-ep.yaml#"
> -
> properties:
> compatible:
> oneOf:
> @@ -65,6 +62,31 @@ properties:
> items:
> - const: link_state
>
> +allOf:
> + - $ref: "cdns-pcie-ep.yaml#"

While moving it, drop the quotes.

> + - if:
> + properties:
> + compatible:
> + enum:
> + - ti,am64-pcie-ep
> + then:
> + properties:
> + num-lanes:
> + minimum: 1
> + maximum: 1
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - ti,j7200-pcie-ep
> + - ti,j721e-pcie-ep
> + then:
> + properties:
> + num-lanes:
> + minimum: 1
> + maximum: 2
> +
> required:
> - compatible
> - reg
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index b0513b197d08..8eca0d08303f 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -10,9 +10,6 @@ title: TI J721E PCI Host (PCIe Wrapper)
> maintainers:
> - Kishon Vijay Abraham I <kishon@xxxxxx>
>
> -allOf:
> - - $ref: "cdns-pcie-host.yaml#"
> -
> properties:
> compatible:
> oneOf:
> @@ -98,6 +95,31 @@ properties:
> interrupts:
> maxItems: 1
>
> +allOf:
> + - $ref: "cdns-pcie-host.yaml#"

Same here.

> + - if:
> + properties:
> + compatible:
> + enum:
> + - ti,am64-pcie-host
> + then:
> + properties:
> + num-lanes:

const: 1



Best regards,
Krzysztof