Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in srp_parse_options()

[wangyufen]

在 2022/11/26 20:03, Andy Shevchenko 写道:
> On Sat, Nov 26, 2022 at 02:02:14PM +0200, Andy Shevchenko wrote:
> > On Sat, Nov 26, 2022 at 11:35:04AM +0800, Wang Yufen wrote:
>
> ...
>
> > >   			target->scsi_host->can_queue);
> >
> > The below can't be like this, right?
> >
> > > +out_with_einval:
> > > +	ret = -EINVAL;
> > >   out:
> > >   	kfree(options);
> > >   	return ret;
>
> One option is:
>
> out:
> 	kfree(options);
> 	return ret;
>
> out_with_einval:
> 	ret = -EINVAL;
> 	goto out;

I got it.
Thanks!

>