Re: [PATCH net] net: hsr: Fix potential use-after-free

From: YueHaibing
Date: Fri Nov 25 2022 - 02:53:19 EST


On 2022/11/24 16:53, Paolo Abeni wrote:
> Hello,
>
> On Wed, 2022-11-23 at 14:30 +0800, YueHaibing wrote:
>> The skb is delivered to netif_rx() which may free it, after calling this,
>> dereferencing skb may trigger use-after-free.
>>
>> Fixes: f266a683a480 ("net/hsr: Better frame dispatch")
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>
> The code looks good, but the above is not the commit introducing the
> issue, it just move the netif_rx() and later skb access from somewhere
> else.
>
> Please go deeper in git history and find the change that originated the> issue.

Ok, will dig it.

>
> Thanks,
>
> Paolo
>
> .
>