Re: [PATCH v2 0/2] fs: clear a UBSAN shift-out-of-bounds warning

From: Al Viro
Date: Fri Nov 25 2022 - 01:44:02 EST


On Mon, Nov 21, 2022 at 10:44:16AM +0800, Zhen Lei wrote:
> v1 -- > v2:
> 1. Replace INT_LIMIT(loff_t) with OFFSET_MAX in btrfs.
> 2. Replace INT_LIMIT() with type_max().

Looks fine, except that I'd rather go for commit message
along the lines of "INT_LIMIT tries to do what type_max does,
except that type_max doesn't rely upon undefined behaviour;
might as well use type_max() instead"

If you want to credit UBSAN - sure, no problem, just don't
clutter the commit message with that. As it is, it reads
as "make $TOOL STFU"...