RE: [PATCH] spi: cadence-quadspi: Add upper limit safety check to baudrate divisor

From: Nathan Barrett-Morrison
Date: Thu Nov 24 2022 - 06:54:00 EST


Hi Mark & Dhruva,

Your understanding is correct. This is just checking if the divisor field has exceed the bit field's full scale (0xF) in this case. This was observed when we had a reference block of 500MHz and a max SPI clock of 10MHz setting.

500000000/2*10000000 = 25
25 > 0xF (15)

Would you like me to add a dev_err (or such) bailout error condition and resubmit?

Sincerely,
Nathan