Re: [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set

From: Liam Howlett
Date: Wed Nov 23 2022 - 13:54:15 EST



Thanks Randy. I'm going to look into doing as Geert requested and avoid
pulling in dependencies, but this is the right thing to do for now.

Reviewed-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>


* Randy Dunlap <rdunlap@xxxxxxxxxxxxx> [221119 00:51]:
> Prevent a kconfig warning that is caused by TEST_MAPLE_TREE by adding a
> "depends on" clause for TEST_MAPLE_TREE since 'select' does not follow
> any kconfig dependencies.
>
> WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
> Depends on [n]: DEBUG_KERNEL [=n]
> Selected by [y]:
> - TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]
>
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: 120b116208a0 ("maple_tree: reorganize testing to restore module testing")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Liam Howlett <liam.howlett@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2259,6 +2259,7 @@ config TEST_XARRAY
> tristate "Test the XArray code at runtime"
>
> config TEST_MAPLE_TREE
> + depends on DEBUG_KERNEL
> select DEBUG_MAPLE_TREE
> tristate "Test the Maple Tree code at runtime"
>