RE: [PATCH 5/6] x86/hyperv: Support hypercalls for TDX guests

From: Dexuan Cui
Date: Wed Nov 23 2022 - 13:15:57 EST


> From: Kirill A. Shutemov <kirill@xxxxxxxxxxxxx>
> [...]
> > >
> > > The "no #ifdef's in C files" rule would be good to apply here. Please
> > > do one #ifdef in a header.
> >
> > Sorry, I should use #ifdef rather than #if. I'll fix it like the below.
>
> No, can we hide preprocessor hell inside hv_isolation_type_tdx()?
>
> Like make it return false for !CONFIG_INTEL_TDX_GUEST and avoid all
> #if/#ifdefs in C file.

Ok, let me try to apply Michael's good ideas he shared in another email.