Re: [PATCH mm-unstable v4 06/10] mm/hugetlb: convert add_hugetlb_page() to folios and add hugetlb_cma_folio()

[Sidhartha Kumar]

On 11/23/22 1:29 AM, David Hildenbrand wrote:
> On 18.11.22 23:19, Sidhartha Kumar wrote:
> > Convert add_hugetlb_page() to take in a folio, also convert
> > hugetlb_cma_page() to take in a folio.
> >
> > Signed-off-by: Sidhartha Kumar <sidhartha.kumar@xxxxxxxxxx>
>
> [...]
>
> >   @@ -1525,21 +1525,21 @@ static void add_hugetlb_page(struct hstate 
> > *h, struct page *page,
> >           h->surplus_huge_pages_node[nid]++;
> >       }
> >   -    set_compound_page_dtor(page, HUGETLB_PAGE_DTOR);
> > -    set_page_private(page, 0);
> > +    folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR);
> > +    folio_change_private(folio, 0);
>
> As raised (CC'ed you), this should be s/0/NULL/

Sure, I'll make this change in my next version.

Thanks,

Sidhartha Kumar