Re: [PATCH 1/2] serial: atmel: cleanup atmel_start+stop_tx()

From: Richard Genoud
Date: Wed Nov 23 2022 - 08:01:27 EST


Le 23/11/2022 à 09:50, Michael Walle a écrit :
> Am 2022-11-23 09:27, schrieb Jiri Slaby (SUSE):
>> Define local variables holding information about whether pdc or dma is
>> used in the HW. These are retested several times by calls to
>> atmel_use_pdc_tx() and atmel_use_dma_tx(). So to make the code more
>> readable, simply cache the values.
>>
>> This is also a preparatory patch for the next one (where is_pdc is used
>> once more in atmel_stop_tx()).
>>
>> Cc: Richard Genoud <richard.genoud@xxxxxxxxx>
>> Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>
>> Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
>> Cc: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
>> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>> Reported-by: Michael Walle <michael@xxxxxxxx>
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
>
> Already merged, but:
> Tested-by: Michael Walle <michael@xxxxxxxx>
Acked-by: Richard Genoud <richard.genoud@xxxxxxxxx>
>
> Thanks,
> -michael
Thanks !