RE: [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver

[Sathyakam M]

Hi Krzysztof,
Thank you for taking your time to review the patches.

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
> Sent: 21 November 2022 15:01
> To: Sathyakam M <sathya@xxxxxxxxxxx>
> Cc: Kishon Vijay Abraham I <kishon@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Pankaj Kumar Dubey
> <pankaj.dubey@xxxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>;
> Aswani Reddy <aswani.reddy@xxxxxxxxxxx>; Andi Shyti
> <andi@xxxxxxxxxxx>; Hans Verkuil <hverkuil-cisco@xxxxxxxxx>; Ming Qian
> <ming.qian@xxxxxxx>; Jacopo Mondi <jacopo@xxxxxxxxxx>; Will Deacon
> <will@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Marcel Ziswiler
> <marcel.ziswiler@xxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 0/5] media: add FSD MIPI-CSI2 Rx controller driver
> 
> On 20/11/2022 19:52, Sathyakam M wrote:
> > This patch series adds the V4L2 media driver for Tesla Full Self
> > Driving (FSD) SoC MIPI-CSI2 Rx controller.
> >
> > The controller is compliant to MIPI CSI2 v1.3 specification.
> > It receives images from camera sensors over the D-PHY interface.
> >
> > The D-PHY interface is compliant to MIPI D-PHY v1.2 specification. It
> > supports up to maximum of 4 data lanes.
> >
> > V4L2 user control is provided to set the desired number of data lanes.
> >
> > Maximum of up to 4 streams can be received simultaneously by one Rx
> > port. (Each streams identified by designated Virtual Channel
> > Identifier).
> >
> > The controller instances consist of port property describing the endpoints.
> > When combined with remote-endpoint property the driver instantiates
> > video device nodes using V4L2 async subdev methods.
> >
> > Streaming formats supported:
> > - YUV420
> > - RGB565, RGB666, RGB888
> > - RAW8, RAW10, RAW12
> > - JPEG
> >
> > The driver implementation is verified on FSD evaluation board.
> >
> > Thanks, Sathyakam
> >
> > Cc: Sathyakam M <sathya@xxxxxxxxxxx>,Vinod Koul <vkoul@xxxxxxxxxx>
> > Cc: Kishon Vijay Abraham I <kishon@xxxxxxxxxx>,Rob Herring
> > <robh+dt@xxxxxxxxxx>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> > Cc: Pankaj Kumar Dubey <pankaj.dubey@xxxxxxxxxxx>,Mauro Carvalho
> > Chehab <mchehab@xxxxxxxxxx>
> > Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>,Shashank Prashar
> > <s.prashar@xxxxxxxxxxx>
> > Cc: Aswani Reddy <aswani.reddy@xxxxxxxxxxx>,Chandrasekar R
> > <rcsekar@xxxxxxxxxxx>
> > Cc: Andi Shyti <andi@xxxxxxxxxxx>,Laurent Pinchart
> > <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > Cc: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>,Jernej Skrabec
> > <jernej.skrabec@xxxxxxxxx>
> > Cc: Ming Qian <ming.qian@xxxxxxx>,Dmitry Osipenko
> <digetx@xxxxxxxxx>
> > Cc: Jacopo Mondi <jacopo@xxxxxxxxxx>,Catalin Marinas
> > <catalin.marinas@xxxxxxx>
> > Cc: Will Deacon <will@xxxxxxxxxx>,Bjorn Andersson
> > <andersson@xxxxxxxxxx>
> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>,Arnd Bergmann
> <arnd@xxxxxxxx>
> > Cc: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>,Mark Brown
> > <broonie@xxxxxxxxxx>
> > Cc:
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,linux-phy@xxxxxxxxxxxxxxxxxxx,dev
> > icetree@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx,linux-media@xxxxxxxxxxxxxxx
> >
> > Sathyakam M (5):
> >   dt-bindings: phy: fsd: MIPI CSI2 Rx controller syscon node
> >   media: dt-bindings: fsd: MIPI CSI2 Rx controller device nodes
> >   arm64: dts: fsd: add device tree nodes for MIPI CSI2 Rx controller
> >   media: fsd: add MIPI CSI2 Rx controller driver
> 
> I did not get your patch #4. Don't Cc selectively.
Sorry for that. There was problem with sending the bundled patch set. I see that you got "[PATCH 4/5] media: fsd: add MIPI CSI2 Rx controller driver".
I will address the comments for the same.
> 
> Best regards,
> Krzysztof