Re: [PATCH 1/2] usb: typec: Add helper to get partner device struct

From: Heikki Krogerus
Date: Wed Nov 23 2022 - 03:49:19 EST


On Tue, Nov 22, 2022 at 11:05:04AM -0800, Prashant Malani wrote:
> Hi Heikki,
>
> Thanks for reviewing the patch.
>
> On Tue, Nov 22, 2022 at 1:58 AM Heikki Krogerus
> <heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> >
> > Let's not loose the protection around these devices unless there is no
> > other way, and in this case there is.
> >
> > Please just create a wrapper for usb_power_delivery_register() instead:
> >
> > struct usb_power_delivery *
> > typec_partner_usb_power_delivery_register(struct typec_partner *partner,
> > struct usb_power_delivery_desc *desc)
> > {
> > return usb_power_delivery_register(&partner->dev, desc);
> > }
> > EXPORT_SYMBOL_GPL(typec_partner_usb_power_delivery_register);
>
> Sounds good. I'll send a v2 with the above change as patch 1 (instead
> of the current patch 1).
>
> I will list you as the "Suggested-by" tag (but please let me know if
> you'd like attribution stated differently).

Thanks. Suggested-by is the correct tag IMO.

cheers,

--
heikki