Re: [PATCH] mlx4: use snprintf() instead of sprintf() for safety

[Saeed Mahameed]

On 22 Nov 12:12, Jakub Kicinski wrote:
> On Tue, 22 Nov 2022 16:48:15 +0200 Leon Romanovsky wrote:
> > On Tue, Nov 22, 2022 at 04:04:53PM +0300, Peter Kosyh wrote:
> > > Use snprintf() to avoid the potential buffer overflow. Although in the
> > > current code this is hardly possible, the safety is unclean.
> >
> > Let's fix the tools instead. The kernel code is correct.
>
> I'm guessing the code is correct because port can't be a high value?
> Otherwise, if I'm counting right, large enough port representation
> (e.g. 99999999) could overflow the string. If that's the case - how
> would they "fix the tool" to know the port is always a single digit?

+1 

FWIW,

Reviewed-by: Saeed Mahameed <saeed@xxxxxxxxxx>