Re: [PATCH v2 4/5] blk-iocost: fix sleeping in atomic context warnning

From: Tejun Heo
Date: Tue Nov 22 2022 - 19:42:15 EST


On Tue, Nov 22, 2022 at 05:14:29PM -0700, Jens Axboe wrote:
> >> Then match_strdup() and kfree() in match_NUMBER() can be replaced with
> >> get_buffer() and put_buffer().
> >
> > Sorry about the late reply. Yeah, something like this.
>
> Doesn't local_irq_disable() imply preemption disable as well?

Right, I was thinking about spin_lock_irq() which doesn't imply disabling
preemption in PREEMPT_RT. local_irq_disable() is actual irq disable even on
RT. It should be fine on its own.

Thanks.

--
tejun