Re: [PATCH v7 2/7] media: dt-binding: nuvoton: Add bindings for NPCM VCD and ECE engine

From: Rob Herring
Date: Tue Nov 22 2022 - 19:06:00 EST


On Tue, Nov 22, 2022 at 04:57:19PM +0800, Marvin Lin wrote:
> Add dt-binding document for Video Capture/Differentiation Engine (VCD)
> and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs.
>
> Signed-off-by: Marvin Lin <milkfafa@xxxxxxxxx>
> ---
> .../bindings/media/nuvoton,npcm-video.yaml | 87 +++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml b/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml
> new file mode 100644
> index 000000000000..b5be7ef09038
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-video.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/nuvoton,npcm-video.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM Video Capture/Encode Engine Device Tree Bindings

Drop ' Device Tree Bindings'

> +
> +maintainers:
> + - Joseph Liu <kwliu@xxxxxxxxxxx>
> + - Marvin Lin <kflin@xxxxxxxxxxx>
> +
> +description: |
> + Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine
> + (ECE) present on Nuvoton NPCM SoCs.

Sounds like 2 h/w blocks? If so, then it should be 2 separate nodes.

> +
> +properties:
> + compatible:
> + enum:
> + - nuvoton,npcm750-video
> + - nuvoton,npcm845-video

'video' doesn't sound like the name of the h/w block(s).

> +
> + reg:
> + items:
> + - description: VCD registers
> + - description: ECE registers
> +
> + reg-names:
> + items:
> + - const: vcd
> + - const: ece
> +
> + interrupts:
> + maxItems: 1
> +
> + resets:
> + items:
> + - description: VCD reset control
> + - description: ECE reset control
> +
> + reset-names:
> + items:
> + - const: vcd
> + - const: ece
> +
> + nuvoton,syscon-gcr:
> + $ref: /schemas/types.yaml#definitions/phandle
> + description: Phandle to the Global Control Register DT node
> +
> + nuvoton,syscon-gfxi:
> + $ref: /schemas/types.yaml#definitions/phandle
> + description: Phandle to the Graphics Core Information DT node
> +
> + memory-region:
> + description:
> + CMA pool to use for buffers allocation instead of the default CMA pool.
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - interrupts
> + - resets
> + - reset-names
> + - nuvoton,syscon-gcr
> + - nuvoton,syscon-gfxi
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/reset/nuvoton,npcm7xx-reset.h>
> +
> + video: video@f0810000 {
> + compatible = "nuvoton,npcm750-video";
> + reg = <0xf0810000 0x10000>,
> + <0xf0820000 0x2000>;
> + reg-names = "vcd", "ece";
> + interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_VCD>,
> + <&rstc NPCM7XX_RESET_IPSRST2 NPCM7XX_RESET_ECE>;
> + reset-names = "vcd", "ece";
> + nuvoton,syscon-gcr = <&gcr>;
> + nuvoton,syscon-gfxi = <&gfxi>;
> + };
> --
> 2.34.1
>
>