Re: [patch 06/15] timers: Update kernel-doc for various functions

From: Steven Rostedt
Date: Tue Nov 22 2022 - 10:38:47 EST


On Tue, 22 Nov 2022 16:18:37 +0100
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> >> *
> >> - * The function returns whether it has deactivated a pending timer or not.
> >> - * (ie. del_timer() of an inactive timer returns 0, del_timer() of an
> >> - * active timer returns 1.)
> >> + * Contrary to del_timer_sync() this function does not wait for an
> >> + * eventually running timer callback on a different CPU and it neither
> >
> > I'm a little confused with the "eventually running timer". Does that simply
> > mean one that is about to run next (that is, it doesn't handle race
> > conditions and the timer is in the process of starting), but will still
> > deactivate one that has not been started and the timer code for that CPU
> > hasn't triggered yet?
>
> Let me try again.
>
> The function only deactivates a pending timer, but contrary to
> del_timer_sync() it does not take into account whether the timers
> callback function is concurrently executed on a different CPU or not.
>
> Does that make more sense?

Yes, much better. Thanks!

-- Steve