Re: [PATCH v2 1/4] i915: Move list_count() to list.h for broader use

From: Andy Shevchenko
Date: Tue Nov 22 2022 - 10:24:17 EST


On Tue, Nov 15, 2022 at 05:46:28PM +0200, Jani Nikula wrote:
> On Mon, 14 Nov 2022, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > Some of the existing users, and definitely will be new ones, want to
> > count existing nodes in the list. Provide a generic API for that by
> > moving code from i915 to list.h.
>
> I think I'd find list_length() a much more natural name for this.

i915 suggests my variant :-)

> *shrug*
>
> Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>
>
> regardless of what you decide to do with name or static inline etc.

Thanks! I will check which one looks and feels better and update for v3.

--
With Best Regards,
Andy Shevchenko