Re: Build regressions/improvements in v6.1-rc6

From: Johannes Berg
Date: Tue Nov 22 2022 - 10:02:35 EST


On Tue, 2022-11-22 at 08:55 -0500, Alex Deucher wrote:
> >
> > + /kisskb/src/arch/um/include/asm/processor-generic.h: error: called object is not a function or function pointer: => 94:18
> > + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: error: control reaches end of non-void function [-Werror=return-type]: => 1934:1
> >
> > um-x86_64/um-all{mod,yes}config (in kfd_cpumask_to_apic_id())
>
> Presumably cpu_data is not defined on um-x86_64? Does it even make
> sense to build drivers on um-x86_64?

Drivers in general yes ;-)

This driver, probably not.

But the issue is that a lot of drivers "depends on X86_64" or such,
where only "X86" is the arch symbol. You could add "X86 && X86_64" to
really build on x86 64-bit only.

I didn't check this driver, but this has mostly popped up since UM got
PCI support some time ago (which I added.)

johannes