Re: [PATCH 2/2] OPP: Disallow "opp-hz" property without a corresponding clk

From: Manivannan Sadhasivam
Date: Tue Nov 22 2022 - 08:26:47 EST


On Mon, Nov 21, 2022 at 02:00:36PM +0530, Viresh Kumar wrote:
> On 21-11-22, 08:42, Johan Hovold wrote:
> > Ok, I was expected the devicetree update to through Bjorn's tree as I
> > imagine there may be conflicts otherwise.
>
> Dropped the DT patch now.
>
> Mani, I believe the first patch in this series is still required.
> Without that, when the cpufreq driver calls dev_pm_opp_set_opp(), the
> OPP core may end up calling clk_set_rate(), which shouldn't be done in
> case of Qcom SoCs.
>

If there is no .set_rate() callback implemented by the clock provider, it won't
hurt, right?

Thanks,
Mani

> I am not sure though, how it will work with sc8280xp. Can you please
> check ?
>
> --
> viresh

--
மணிவண்ணன் சதாசிவம்