Re: [PATCH v2] device property: fix of node refcount leak in fwnode_graph_get_next_endpoint()

From: Andy Shevchenko
Date: Tue Nov 22 2022 - 08:17:03 EST


On Tue, Nov 22, 2022 at 09:12:41PM +0800, Yang Yingliang wrote:
> On 2022/11/22 20:54, Andy Shevchenko wrote:
> > On Tue, Nov 22, 2022 at 08:00:39PM +0800, Yang Yingliang wrote:

...

> > It seems too complicated for the simple fix.
> >
> > As I said, just drop const qualifier and add fwnode_handle_get() in the 'else'
> > branch. This will allow you to drop if (prev) at the end.
>
> fwnode is const, fwnode_handle_get doesn't accept this type.

I'm talking about parent.

--
With Best Regards,
Andy Shevchenko