Re: [PATCH v7 05/20] x86/virt/tdx: Implement functions to make SEAMCALL

From: Peter Zijlstra
Date: Tue Nov 22 2022 - 04:07:02 EST


On Mon, Nov 21, 2022 at 01:26:27PM +1300, Kai Huang wrote:
> +/*
> + * Wrapper of __seamcall() to convert SEAMCALL leaf function error code
> + * to kernel error code. @seamcall_ret and @out contain the SEAMCALL
> + * leaf function return code and the additional output respectively if
> + * not NULL.
> + */
> +static int __always_unused seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9,
> + u64 *seamcall_ret,
> + struct tdx_module_output *out)
> +{

What's the point of a 'static __always_unused' function again? Other
than to test the DCE pass of a linker, that is?