Re: [patch 00/15] timers: Provide timer_shutdown[_sync]()

From: Steven Rostedt
Date: Mon Nov 21 2022 - 21:38:29 EST


On Tue, 15 Nov 2022 21:28:32 +0100 (CET)
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> The patches have been split up into small pieces to make review easier and
> I took the liberty to throw a bunch of overdue cleanups into the picture
> instead of proliferating the existing state further.

After applying all these patches, and then my updates to the rest of
the kernel, as well as my update to the debug objects to require
shutdown. It reported this was needed:

-- Steve

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 0fbb71950ca2..3e84a2621913 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -2188,7 +2188,7 @@ signed long __sched schedule_timeout(signed long timeout)
timer_setup_on_stack(&timer.timer, process_timeout, 0);
__mod_timer(&timer.timer, expire, MOD_TIMER_NOTPENDING);
schedule();
- del_timer_sync(&timer.timer);
+ timer_shutdown_sync(&timer.timer);

/* Remove the timer from the object tracker */
destroy_timer_on_stack(&timer.timer);