Re: [PATCH net-next] net: phy: add Motorcomm YT8531S phy id.

From: Andrew Lunn
Date: Mon Nov 21 2022 - 20:34:44 EST


> #define PHY_ID_YT8511 0x0000010a
> #define PHY_ID_YT8521 0x0000011A
> +#define PHY_ID_YT8531S 0x4F51E91A

The indentation looks odd here.

>
> -/* 0xA000, 0xA001, 0xA003 ,and 0xA006 ~ 0xA00A are common ext registers
> +/* 0xA000, 0xA001, 0xA003 , 0xA006 ~ 0xA00A and 0xA012 are common ext registers

Please remove the space before the ,

> 2.31.0.windows.1

Does that mean you are hosting your Linux builds on Windows machine?

Andrew